[ros2param] Provide tests for ros2param verbs#389
Conversation
Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
hidmic
left a comment
There was a problem hiding this comment.
LGTM but for a few more comments and pending green CI
Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
hidmic
left a comment
There was a problem hiding this comment.
LGTM pending one last CI run
|
Yep, lets hope it doesn't hang |
|
Playing around with a Windows VM I was able to get all test running just fine if and only if I run them individually for each |
I've encountered similar situation when running CI on another |
The hangs in ros2/build_farmer#248 were resolved by eProsima/Fast-DDS#871 and the hung processes were deadlocked requiring a SIGKILL so it is likely something else going on here. |
|
@hidmic I assigned you, so it doesn't appear more in our triage search, I also understand you're planning to follow-up on this. |
As the title says, this PR provides a set of tests covering the usage of all the verbs for ros2param
Connected to ros2/rclpy#455