Conversation
Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
…ests Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
|
Something to notice is that these tests don't run with opensplice. It always hangs for almost all verb conditions which ends up failing every test. I suggest to create an issue for opensplice only. |
Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
|
|
||
| // Put the message into a queue to be processed by the middleware. | ||
| // This call is non-blocking. | ||
| pub_->publish(std::move(msg)); |
There was a problem hiding this comment.
@BMarchi if you check container output, you don't even have to publish.
There was a problem hiding this comment.
I can't see why I don't have to publish, can you explain? The container process is the one who gets the output
There was a problem hiding this comment.
I mean you can simply check the output the container generates on component load, no need for the component to generate extra output or even have any logic beyond these tests' purposes.
Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
|
Currently I'm dealing with the |
|
I wasn't able to find out the reason of why |
As the title says, this PR adds tests for the ros2component cli. It's lacking tests for the standalone verb and opensplice is returning a different code error that needs further investigation.
I wasn't able to separate all the verbs because the container is kept alive for every test case and I'm not sure if we can rerun the container each time a test is run.