Fix field type validation for actions - #993
Open
vpfkfl753 wants to merge 1 commit into
Open
Conversation
Signed-off-by: vpfkfl753 <vpfkfl753@gmail.com>
fujitatomoya
approved these changes
Sep 9, 2026
fujitatomoya
left a comment
Contributor
There was a problem hiding this comment.
lgtm with green CI.
Contributor
|
Pulls: #993 |
Author
|
Linux, Linux-aarch64 and RHEL passed. The Windows build stopped before tests while compiling
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #829.
validate_field_types()raisesAttributeErrorfor parsed actions becauseActionSpecificationhas nogoal_serviceorresult_service. Read the goal, result and feedback fields directly, and remove the unused service annotations.Is this user-facing behavior change?
Action validation now accepts valid fields and raises
UnknownMessageTypefor unknown message types in any of the three sections.Did you use Generative AI?
Yes, OpenAI Codex (GPT-6), for the code change and tests.
Additional Information
Added five regression cases for empty actions, primitive fields and unknown message types in each section. All five fail before the fix. The adapter's 46 Python tests pass in a ROS 2 Rolling container.
colcon buildandcolcon test --packages-select rosidl_adapteralso pass, including mypy and the package's lint checks.