Type hints

[ahcorde]

Description

Type hints

Did you use Generative AI?

Claude Opus 4.7

[mergify]

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

• Queue this pull request

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.20%. Comparing base (51cedf6) to head (f79a3aa).

Additional details and impacted files

@@             Coverage Diff             @@
##           rolling     #394      +/-   ##
===========================================
+ Coverage    88.18%   88.20%   +0.01%     
===========================================
  Files           18       18              
  Lines          601      602       +1     
  Branches        53       53              
===========================================
+ Hits           530      531       +1     
  Misses          52       52              
  Partials        19       19              

Flag	Coverage Δ
unittests	88.20% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ahcorde]

Pulls: #394
Gist: https://gist.githubusercontent.com/ahcorde/682cd702af942d348a4880e8f1b95210/raw/ef5efa12cbe751b579447f3c75864510926f812e/ros2.repos
BUILD args: --packages-above-and-dependencies sros2
TEST args: --packages-above sros2
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19805

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[fujitatomoya]

does this actually pass mypy?

AFAIS, in lxml those are factory functions, not classes? the actual classes are etree._Element and etree._ElementTree. adding these type checks would look ugly a bit, but i believe those types should be used here?

[ahcorde]

• Linux
• Linux-aarch64
• Linux-rhel
• Windows