Replace deprecated spin_until_future_complete#499
Merged
wjwwood merged 2 commits intoros2:masterfrom Jun 24, 2022
Merged
Conversation
Contributor
Author
|
Due to change in RCLCPP - ros2/rclcpp#1874 Pull request |
hliberacki
force-pushed
the
hliberacki/spin_until
branch
2 times, most recently
from
67d88e7 to
8c7e7f0
Compare
fujitatomoya
requested changes
Apr 1, 2022
Contributor
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
same here, we should avoid unnecessary changes. everything else looks good to me.
Signed-off-by: Hubert Liberacki <hliberacki@gmail.com>
hliberacki
force-pushed
the
hliberacki/spin_until
branch
from
8c7e7f0 to
e53b377
Compare
Contributor
Author
|
ros2/rclcpp#1874 (comment) Passing CI with all related PRs linked and build together. |
fujitatomoya
approved these changes
Apr 9, 2022
wjwwood
approved these changes
Jun 24, 2022
Member
|
As @clalancette pointed out, this cannot be merged without ros2/rclpy#919 (review), so I need to revert this until it can be merged. See: #504 un-revert pr open here: #505 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace deprecated spin_until_future_complete with spin_until_complete
Signed-off-by: Hubert Liberacki hliberacki@gmail.com