Allow test_communication to use idl messages#549
Open
MiguelCompany wants to merge 3 commits intoros2:rollingfrom
Open
Allow test_communication to use idl messages#549MiguelCompany wants to merge 3 commits intoros2:rollingfrom
MiguelCompany wants to merge 3 commits intoros2:rollingfrom
Conversation
Contributor
|
@methylDragon @clalancette can you review this? |
Contributor
|
@clalancette can you assign this to yourself? (from waffle triage, but i do not have power...) |
Contributor
Author
|
@clalancette Friendly ping |
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany
force-pushed
the
test-communication-idl-messages
branch
from
a8edc10 to
3542acb
Compare
Contributor
Author
|
@fujitatomoya I rebased this. It is somewhat related to the support for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this PR as requested on #542 (comment).
The CMake on
test_communicationpackage assumes that the messages intest_msgspackage are defined as.msgfiles.Since
.msgfiles are converted into.idlfiles, and both are installed as resources in the ament index, we can always use the.idlones, thus allowing messages to be defined directly in.idlfiles.