Skip to content

fix(sql): correct connection icon reference from duckdb to ducklake - #454

Merged
flakronademi merged 1 commit into
devfrom
fix/select-connections-ducklake-icon
Sep 16, 2026
Merged

flakronademi merged 1 commit into
devfrom
fix/select-connections-ducklake-icon

Conversation

@flakronademi

@flakronademi flakronademi commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • The SQL connection selector now displays the correct DuckLake icon.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 5b9e9754-ebc4-418b-a132-c6130c5ad759

📥 Commits

Reviewing files that changed from the base of the PR and between 9d6e0d2 and 6a1c1f2.

📒 Files selected for processing (1)
  • src/renderer/screens/sql/index.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The SQL connection selector now uses the DuckLake-specific icon and falls back to the default icon when unavailable.

Changes

DuckLake icon selection

Layer / File(s) Summary
Update DuckLake icon fallback
src/renderer/screens/sql/index.tsx
The DuckLake instance image now uses connectionIcons.images.ducklake instead of connectionIcons.images.duckdb, with defaultIcon as fallback.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: nuri1977

Merge Risk: ⚪ Minimal · up to 6a1c1

No merge-blocking behavior is identified in this icon-only change.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: correcting the SQL connection selector icon reference from DuckDB to DuckLake.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/select-connections-ducklake-icon

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@flakronademi
flakronademi merged commit dcb49e0 into dev Sep 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants