implement telemetry report parsing #76
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossengeorgiev
requested changes
Sep 21, 2022
Owner
rossengeorgiev
left a comment
rossengeorgiev
left a comment
There was a problem hiding this comment.
Changese includes formating changes which are not part of PR, and only add noise. Leave them out
stefanolande
force-pushed
the
master
branch
from
a6ad91c to
a01f7e2
Compare
Author
|
Done, I cleaned up the PR. |
stefanolande
force-pushed
the
master
branch
from
d52e9b3 to
09ac002
Compare
Author
|
Also rebased from master. |
|
This looks good (and the ouptut format matches up with decoded base91 telemetry, unlike #78). I would love to see a merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format uses floats for telemetry values as a lot of softwares are not compliant with the APRS101 spec - see this report.
Floats can deserialise message compliant with the spec, but is up to the user of the library to treat the values as decimals or bytes.