Ignore timed out errors when not blocking #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gerard Hickey <hickey@kinetic-compute.com>
Author
|
@rossengeorgiev Just looking to get your eyes on this. |
Author
|
The other thought here is to remove the logging statement and raise the exception to allow the calling code to decide how to handle the timeout. That might actually be the better option except it is a breaking change for anyone using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one attempts to use
aprslibin a non-blocking fashion, then every time that there is a read of the socket and there are not any frames to be read an error message gets sent through the logger. This is not actually an error but expected. So this patch will just squash thetimed outerrors when_socket_readlines()is called withblocking=False.