Skip to content

test(proxy): make the dangling-marker assertion baseline-relative, not absolute #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amiddavid merged 1 commit into from
Sep 3, 2026
+11 −3
Merged

test(proxy): make the dangling-marker assertion baseline-relative, not absolute #203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions proxy/stashreserve_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ func TestAnExhaustedRewindReserveNeitherStampsUnbackedMarkersNorHidesItself(t *t
if err != nil {
t.Fatal(err)
}
// Captured before the request, so the dangling-marker assertion below measures what THIS
// fixture did rather than what the whole test binary has accumulated.
missingBefore := offloadStashMissing()
resp, err := http.Post(srv.URL+"/openai/v1/chat/completions", "application/json", strings.NewReader(string(body)))
if err != nil {
t.Fatal(err)
Expand Down Expand Up @@ -158,9 +161,14 @@ func TestAnExhaustedRewindReserveNeitherStampsUnbackedMarkersNorHidesItself(t *t
t.Error(`/stats does not render a "stash_missing" key, so the one reserve outcome that ` +
`genuinely breaks reversibility is indistinguishable from the safe one`)
}
if snap.StashMissing != 0 {
t.Errorf("/stats stash_missing = %d in a fixture where every refusal left the content "+
"verbatim; a declined removal is being counted as a dangling marker", snap.StashMissing)
// BASELINE-RELATIVE, because StashMissing is a PROCESS-WIDE counter shared with every other
// test in this binary — TestStatsPublishesDanglingReplaysFromTheLiveCounter below deliberately
// drives it non-zero. An absolute `!= 0` therefore passed on the first run and failed on the
// second under -count=2, which is the class of defect #192 already documents; this assertion
// was a third instance of it.
if got := snap.StashMissing - missingBefore; got != 0 {
t.Errorf("/stats stash_missing moved by %d in a fixture where every refusal left the "+
"content verbatim; a declined removal is being counted as a dangling marker", got)
}
}

Expand Down
Loading