-
Notifications
You must be signed in to change notification settings - Fork 40
refactor: ♻️👷 Use common tags for plugin lite builds #861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,10 +52,9 @@ jobs: | |
| # authbridge-proxy variants: "<suffix>:<build-tags>". Empty | ||
| # suffix is the default plugin set. One variant per opt-in | ||
| # plugin (or one combined "full") — never enumerate combos. | ||
| lite_tags="exclude_plugin_a2aparser,exclude_plugin_ibac" | ||
| lite_tags="${lite_tags},exclude_plugin_inferenceparser" | ||
| lite_tags="${lite_tags},exclude_plugin_mcpparser,exclude_plugin_opa" | ||
| lite_tags="${lite_tags},exclude_plugin_sparc,exclude_plugin_tokenbroker" | ||
| # Lite tags are derived from plugin source; see | ||
| # authbridge/scripts/lite-tags. | ||
| lite_tags=$(go -C authbridge/scripts/lite-tags run .) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: worth a line in the release notes. The list this replaces omitted |
||
| declare -a proxy_variants=( | ||
| ":" | ||
| "lite:${lite_tags}" | ||
|
|
@@ -112,7 +111,7 @@ jobs: | |
| add '' | ||
| add '`authbridge-proxy` ships in variants matching the container images:' | ||
| add 'unqualified (default plugin set, matches the `authbridge` image),' | ||
| add '`-lite` (auth-only, matches `authbridge-lite`), plus one variant per' | ||
| add '`-lite` (trimmed plugin set, matches `authbridge-lite`), plus one variant per' | ||
| add 'opt-in plugin currently offered for try-out (today: `-sessionbudget`).' | ||
| add 'Variants track opt-in plugins one-for-one; arbitrary combinations are not published.' | ||
| add '' | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: the comment four lines above this (line 104) still reads
# with exclude_plugin_* tags (only jwt-validation + token-exchange).That is the exact duplicated claim this PR exists to eliminate, and it is now wrong twice over —liteKeephas four entries, so lite also retainslitellm_budgettrackandstaticinject.Suggest replacing it with a pointer to the generator, matching what you did in the other five docs: