Skip to content

Fix: explain a script/binary version mismatch instead of dying on an unknown flag #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huang195 wants to merge 1 commit into from
Closed

Fix: explain a script/binary version mismatch instead of dying on an unknown flag #875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions authbridge/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,34 @@ rm -rf "$tmp"
trap - EXIT
fi # end of download block

# --- refuse to drive binaries older than this script ---
#
# The script and the binaries can come from different releases: when the resolved
# release has no authbridge/install.sh the bootstrap falls back to the copy from
# main, but the BINARIES still come from that older release. A newer script then
# passes flags and subcommands the older binaries never had, and the run dies
# deep in startup with "flag provided but not defined: -local" — which reads like
# a bug in Cortex rather than a version mismatch.
#
# Probing the flag beats comparing version strings: the flags are the actual
# contract, and a probe needs no updating when the scheme changes. `--local`
# arrived in the same change as abctl's `claude-code` and `tools scan`
# subcommands, so it stands in for all of them.
if ! "${BIN_DIR}/authbridge-proxy" --help 2>&1 | grep -q -- '-local'; then
# Deliberately not suggesting --ref=${version}: a release old enough to fail
# this probe is old enough that its tree has no authbridge/install.sh either,
# so the bootstrap would 404, fall back to main, and land right back here.
die "the ${version} binaries are older than this installer.
They have no --local (it was --demo then), and their abctl has no claude-code
or tools subcommands, so this script cannot drive them — and no installer can
give you --claude-code from ${version}, because the feature is not in it.
Either:
wait for a release newer than ${version}, or set
AUTHBRIDGE_VERSION=<newer tag> to install newer binaries with this script;
or run that release's own installer, which matches its binaries:
curl -fsSL https://raw.githubusercontent.com/${REPO}/${version}/authbridge/install-demo.sh | sh"
fi

# --- report ---
proxy="${BIN_DIR}/authbridge-proxy"
ca_dir="${CORTEX_DIR}/ca" # matches defaultCortexDir()+caDirName in local.go
Expand Down
Loading