refactor(api): remove spec.trace from AgentRuntime CRD

[rh-dnagornuks]

Summary

Removes the per-workload tracing configuration (spec.trace) from the AgentRuntime CRD, along with the TraceSpec, SamplingSpec, and TraceProtocol types. Tracing configuration was never consumed by any reconciliation or injection path. — the ResolvedConfig.TraceEndpoint/TraceProtocol/TraceSamplingRate fields were populated from the CR but never consumed by the pod mutator or container builder, making them dead code from inception. The MLflow controller also has no trace/OTEL references.

Changes

• Remove TraceSpec, SamplingSpec, and TraceProtocol types from agentruntime_types.go
• Remove spec.trace field from AgentRuntimeSpec and regenerate CRD manifests / deepcopy
• Remove trace-related overrides from AgentRuntimeOverrides and extractOverrides in the webhook injector
• Remove traceConfig struct and Trace field from the controller's resolvedConfig (config-hash computation)
• Remove dead TraceEndpoint/TraceProtocol/TraceSamplingRate fields from ResolvedConfig — these were never read by any code path
• Remove trace override application from ResolveConfig
• Update sample YAML and documentation: remove trace mention
• Remove all trace-specific test cases

Testing

• make fmt vet and make test — pass
• pre-commit run --all-files — all hooks pass
• Deployed to live cluster — AgentRuntime CRD doesn't contain trace related fields

Related Issues

Resolves: RHAIENG-4932 (partial — trace removal only; identity retained)

Made with Cursor

[pdettori]

Clean, thorough removal of dead spec.trace code from the AgentRuntime CRD. The TraceSpec, SamplingSpec, and TraceProtocol types were populated from the CR but never consumed by any reconciliation or injection path — genuine dead code from inception.

Areas reviewed: Go (API types, controller, webhook/injector), Helm/CRD manifests, Docs, Tests, YAML samples, Security, Commit conventions

Spec alignment (specs/001-agentcard-into-status/): No conflict. That spec adds status.card (card discovery) while this PR removes dead fields from spec.trace — orthogonal subresources and concerns. spec.identity (SPIFFE) is preserved, which the card-discovery mTLS path depends on.

CI: All 15 checks passing.
Commit: Single squashed commit, DCO signed-off, conventional format.

No issues found. LGTM.