-
Notifications
You must be signed in to change notification settings - Fork 6
docs(demos): offer sandbox placement for /promote, now that --exclude-prompt exists #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pdettori
merged 2 commits into
rossoctl:main
from
pdettori:feat/promote-parity-placement
Sep 4, 2026
+85
−15
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion — This is true of the digests but not of the invocation quoted in Act 2a (line 260):
That block is introduced as "the command it runs" and sits immediately below the
12288 bytes/sha256:43b8c4c0…output — but under Option B what/promoteactually runs carries--exclude-prompt promote, and the quoted form as written produces 19456 bytes. That is the very discrepancy this PR measured.Since the block exists to be read aloud, an Option B performer would be narrating a command that neither matches what just ran nor yields the digest on screen. A parenthetical at line 260 would close it — e.g.
(plus --exclude-prompt promote under Option B)— and would make the "holds for both" claim here fully literal.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 2a18d63 — and this was the sharpest of the three, because the PR reproduced in its own narration the exact discrepancy it measured. The block now reads:
plus a line saying the flag is not cosmetic: without it the bundle is 19456 bytes rather than the 12288 printed above. So "either option produces the same bundle" is now literally true of the command on screen, not only of the digests.