fix(exgentic_a2a_runner): create openai-secret when missing and report patch failures - #71
Open
esnible wants to merge 1 commit into
Open
fix(exgentic_a2a_runner): create openai-secret when missing and report patch failures#71esnible wants to merge 1 commit into
esnible wants to merge 1 commit into
Conversation
…t patch failures - update-secrets.sh: create openai-secret with key "apikey" if it does not exist, instead of failing; mirrors the existing hf-secret handling - update-secrets.sh: capture kubectl stderr so update/create failures print the reason rather than discarding it via 2>/dev/null - deploy-benchmark.sh: surface update-secrets.sh output and abort the deploy when openai-secret cannot be set Assisted-by: Claude <noreply@anthropic.com> Signed-off-by: Ed Snible <snible@us.ibm.com>
Member
Author
|
@webchang reports that this is related to rossoctl/rossoctl#2486 . Rossoctl no longer always creates the secret, so creating it in workload-harness will make Workload Harness able to handle those Rossoctl installs that didn't have the secret. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update-secrets.shpatchedopenai-secretunconditionally and sent kubectl's stderr to/dev/null, so a missing secret failed with no reason shown.openai-secretwith keyapikeywhen it doesn't exist, instead of failing. Mirrors the existinghf-secrethandling; key name matches thesecretKeyRefink8s/job.yaml.deploy-benchmark.shnow echoes the secrets output and aborts whenopenai-secretcan't be set, rather than deploying with a stale key.Verified with a stubbed
kubectlacross: secret missing (creates), secret exists (patches), patch fails (reason shown), create fails (reason shown),OPENAI_API_KEYunset (skips). Both scripts passbash -n.Note:
update-secrets.shis also called bydeploy-agent.sh, which gains the create-if-missing behavior but not the abort-on-failure guard.🤖 Generated with Claude Code