fix: restrict face registration by event log access - #10
Open
chekmari wants to merge 1 commit into
Open
Conversation
Hide face registration controls when the subscriber cannot access the event log. - pass hasPlog availability to face settings - keep registered faces available for non-owner subscribers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
hasPlogavailability from address settings to face settings.Why
Faces can only be registered from event log entries. Subscribers without event log access should still be able to view registered faces, but should not see or invoke registration controls.
Validation
xmllint --noout presentation/src/main/res/navigation/settings.xmlgit diff --checkhasPlog/canAddFacepropagation pathBuild was not run.