Comprehensively align Pulumi Input/Output typing across components#7
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Input/Outputtypings (follow-up to issue Pulumi Input/Output typing consistency audit #6) so runtime and plan-time behavior match type annotations.len/indexing) can be used on Pulumi inputs.Description
regiononEKSClusteras apulumi.Input[str] | Noneand store it as apulumi.Output[str]usingpulumi.Output.from_input(...)so downstream providers accept dynamic inputs.pulumi.Input[Sequence[pulumi.Input[str]]]forEKSCluster,KarpenterAddon, andEFSCSIAddon, and update helper signatures increate_default_efs_fs_and_sc(...)accordingly.Sequence[pulumi.Input[str]]forSkyPilotServiceDiscoveryandTailscaleSubnetRouterto reflect that code useslen, indexing, or immediate iteration.VPC.public_subnet_idconsistently anOutput(usepulumi.Output.from_input(None)when absent) and correctVPCPeeredGroup.vpc_cidrstyping fromOutput[dict[str,str]]todict[str,str]to match runtime behavior.TailscaleSubnetRouterwithget_secret_version_output(...)and propagate secret values via.apply(...), wiringclient_id/client_secretinto the KubernetesSecretas Pulumi outputs and raising a clearValueErrorif the secret payload is empty.Testing
uv run ruff check pulumi_eks_mland linting passed (All checks passed!).uv run pytest -q tests/unitand all unit tests succeeded (12 passed).Codex Task
Note
Medium Risk
Touches core infrastructure components (EKS/VPC/Tailscale/SkyPilot) and changes how secrets and RBAC defaults are wired, which can affect deployment behavior and initial access control if misconfigured.
Overview
Makes SkyPilot’s default RBAC role configurable via new
hub.skypilot.default_user_role(plumbed from project config intoSkyPilotAPIServerand into the generated API service config), and updates deployment docs to bootstrap withadminthen switch back touser, including a recovery path.Aligns Pulumi
Input/Outputtyping across components to avoid plan-time sync behavior: treatsEKSCluster.regionas anOutput, standardizes subnet ID parameters toInput[Sequence[Input[str]]], and tightens other sequence-typed inputs (SkyPilotServiceDiscovery,TailscaleSubnetRouter).TailscaleSubnetRouteralso switches toget_secret_version_output(...).apply(...)for Secrets Manager payloads.Removes the exported
ingress_statusoutput, makesVPC.public_subnet_idconsistently anOutput(includingNone), correctsVPCPeeredGroup.vpc_cidrstyping, and bumpspulumi-eks-mlto0.2.0.Written by Cursor Bugbot for commit 2c894ea. This will update automatically on new commits. Configure here.