Remove unnecessary/deprecated apps from README#49
Open
milesmcc wants to merge 1 commit intoroverdotcom:masterfrom
Open
Remove unnecessary/deprecated apps from README#49milesmcc wants to merge 1 commit intoroverdotcom:masterfrom
milesmcc wants to merge 1 commit intoroverdotcom:masterfrom
Conversation
The `django.contrib.webdesign` app has been [deprecated](https://docs.djangoproject.com/en/1.8/ref/contrib/webdesign/) since Django 1.8, and including it in the README here could have two negative consequences: * Given its placement, potential users might think using/installing these Django apps is necessary to use the library, which is not the case * It might make it seem like the library hasn't been meaningfully updated since Django 1.8, which is also not the case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! Thanks for the awesome library.
As I was installing this for my own project, I noticed a small problem. The
django.contrib.webdesignapp has been deprecated since Django 1.8, and including it in the README here could have two negative consequences:Hope this is helpful!