Conversation
…ime / Resolved time)
A Freshdesk standard ticket export labels its timestamps "Created time",
"Closed time" and "Resolved time" (Freshworks support: "How do I export my
tickets from Freshdesk?"). After lower() those keep the space, so none of the
three matched the alias table and a native export silently lost both
timestamps - the recount could not place a single line in time.
Adds the three space-form headers to registry/vendor-rules.json
column_aliases ("Resolved time" joins the existing Zendesk "Solved at"
mapping to closed_at). registry/ stays the single source of truth: the
healthcheck copy is synced and website/vendor-rules.js is regenerated with
scripts/gen_web_rules.py.
Tests: 452 -> 454 (Freshdesk style headers map; Resolved time maps closed_at).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23.
What
Adds the native Freshdesk ticket-export headers to
registry/vendor-rules.jsoncolumn_aliases:Created timeopened_atClosed timeclosed_atResolved timeclosed_atResolved timejoins the existing ZendeskSolved at/Closed atmapping —either status ends the conversation, so both land on
closed_at.Why
A Freshdesk standard ticket export labels its timestamps
Created time/Closed time/Resolved time(Freshworks support, How do I export my ticketsfrom Freshdesk?). After
lower()those keep the space, so none of them matchedthe alias table and a native export silently lost both timestamps — the
recount could not place a single line in time.
Ticket IDalready mapped viathe existing
ticket idalias, so the id column was fine.This is the same class of fix as commit ec0d06a (Zendesk space-form aliases):
data-only, no engine code, registry stays the single source of truth.
Files
registry/vendor-rules.json— the three aliases (source of truth)healthcheck/am_healthcheck/vendor-rules.json— synced copywebsite/vendor-rules.js— regenerated viapython3 scripts/gen_web_rules.py --buildhealthcheck/tests/test_vendors.py— two tests inTestNativeHeaderAliasesVerification
python3 -m unittest discover -s healthcheck/tests→ 454 tests, OK (was 452)python3 healthcheck/agentmeasure selftest→ PASSpython3 scripts/gen_web_rules.py --check→ in syncpython3 verify_vectors.py→ ALL VECTORS PASSNotes
Agent/Resolution statuswere deliberately not aliased tohuman_agent_participated/issue_addressed. An assigned agent is a lead,not proof a human finished the conversation, and the status codes
(2 Open / 3 Pending / 4 Resolved / 5 Closed) are not an issue-addressed
judgement — those belong in a
prepare_hintsblock, andprepare --vendor freshdeskwould need a matchingvendors.freshdeskbilling block first, soit is left for a separate change.
healthcheck/tests/test_vendors.pyhasif __name__ == "__main__": unittest.main()beforeTestNativeHeaderAliases,so running that file directly skips the class (discovery still finds it).
Happy to move the guard to the end in this PR if you want.