Draft
Fix --reference filtering + document --fixed-y and --reference usage#139
Conversation
…w CLI args Co-authored-by: mandarmp <33731455+mandarmp@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix reference tag usage in IPN analysis routine
Fix --reference filtering to use resolved config values in pipeline driver
Mar 5, 2026
Co-authored-by: mandarmp <33731455+mandarmp@users.noreply.github.com>
Copilot
AI
changed the title
Fix --reference filtering to use resolved config values in pipeline driver
Fix --reference filtering + document --fixed-y and --reference usage
Mar 6, 2026
6e13863 to
d7b5b2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--referenceflag inrun_pipeline_driver.pywas readingargs.reference/args.typedirectly, bypassingresolve_args()entirely — so anyreference_file/assay_typesvalues set in a config JSON were silently ignored. Additionally,--fixed-y(added in #137) was never added to the README, and no usage example existed for--reference.Code fix
run_pipeline_driver.py: switch reference filtering to useresolved["reference_file"]andresolved["assay_types"]so the config → CLI priority chain is respectedDocs (
IPNAnalysis/README.md,README.md)--fixed-yrow to therun_pipeline_driver.pyCLI reference table--reference/--typeworkflow example (with note on required Excel columns)--fixed-yworkflow example--referencequick-start snippet to top-levelREADME.md💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.