Skip to content

Fix --reference filtering + document --fixed-y and --reference usage#139

Draft
mandarmp with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-ipn-analysis-reference-tag
Draft

Fix --reference filtering + document --fixed-y and --reference usage#139
mandarmp with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-ipn-analysis-reference-tag

Conversation

Copilot AI commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

The --reference flag in run_pipeline_driver.py was reading args.reference / args.type directly, bypassing resolve_args() entirely — so any reference_file / assay_types values set in a config JSON were silently ignored. Additionally, --fixed-y (added in #137) was never added to the README, and no usage example existed for --reference.

Code fix

  • run_pipeline_driver.py: switch reference filtering to use resolved["reference_file"] and resolved["assay_types"] so the config → CLI priority chain is respected
# Before
if args.reference:
    df = pd.read_excel(args.reference)
    filtered = df[df['Assay'].str.lower().isin([t.lower() for t in args.type])]

# After
if resolved["reference_file"]:
    df = pd.read_excel(resolved["reference_file"])
    filtered = df[df['Assay'].str.lower().isin([t.lower() for t in resolved["assay_types"]])]

Docs (IPNAnalysis/README.md, README.md)

  • Add --fixed-y row to the run_pipeline_driver.py CLI reference table
  • Add §9: --reference / --type workflow example (with note on required Excel columns)
  • Add §10: two-step --fixed-y workflow example
  • Add --reference quick-start snippet to top-level README.md

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…w CLI args

Co-authored-by: mandarmp <33731455+mandarmp@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix reference tag usage in IPN analysis routine Fix --reference filtering to use resolved config values in pipeline driver Mar 5, 2026
Co-authored-by: mandarmp <33731455+mandarmp@users.noreply.github.com>
Copilot AI changed the title Fix --reference filtering to use resolved config values in pipeline driver Fix --reference filtering + document --fixed-y and --reference usage Mar 6, 2026
@mandarmp mandarmp force-pushed the copilot/fix-ipn-analysis-reference-tag branch from 6e13863 to d7b5b2a Compare April 28, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants