Draft
Fix fixed-y max calculation to use full plot_data signals#173
Conversation
Copilot created this pull request from a session on behalf of
mandarmp
May 30, 2026 00:26
View session
Copilot
AI
changed the title
Make
Clarify raster semantics and swap network subplot y-axes
May 30, 2026
--fixed-y regenerate plots from saved network outputs when spike times are unavailable
Copilot
AI
changed the title
Clarify raster semantics and swap network subplot y-axes
Plot raster by physical channels and align network subplot axes
May 30, 2026
Copilot
AI
changed the title
Plot raster by physical channels and align network subplot axes
Make May 30, 2026
--fixed-y derive project-wide y-max from existing results
Copilot
AI
changed the title
Make
Make May 30, 2026
--fixed-y derive project-wide y-max from existing results--fixed-y default to existing-data replot mode
Copilot
AI
changed the title
Make
Avoid burst re-analysis when generating May 30, 2026
--fixed-y default to existing-data replot mode--fixed-y plots
Copilot
AI
changed the title
Avoid burst re-analysis when generating
Fix fixed-y max calculation to use full plot_data signals
May 30, 2026
--fixed-y plots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed-y scaling was deriving
y_maxfrom the first non-empty signal inplot_data, which could under-estimate the axis limit when another signal had a higher peak. The fixed-y path now computesy_maxfrom all relevant signals and uses the true maximum.Problem summary
_extract_fixed_y_max, sorate_signalcould mask a largerparticipation_signalpeak (or vice versa).Change made
IPNAnalysis/mea_analysis_routine.pyto:rate_signalandparticipation_signalNoneif no valid data)Effect on behavior
plot_datasignals, improving consistency across wells.