Conversation
…rkflow - adopt pypa's trusted publishing model eliminating api tokens - introduce matrix-based wheel synthesis spanning linux, macos, windows with aarch64 and armv7 - bump maturin-action to stable toolchain, drop explicit version pinning - replace legacy twine upload with native pypi-publish v1 action - unify artifact handling through v4 upload/download with pattern matching - extend interpreter pool to 3.13/3.14 pre-releases, drop eol 3.8 BREAKING CHANGE: python 3.8 support sunset; minimum runtime now 3.9
Summary of ChangesHello @vvanglro, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly overhauls the PyPI publishing pipeline to leverage modern, secure practices. It transitions to PyPA's trusted publishing model, enhancing security by removing API token dependencies. The changes also expand the build matrix for wheel distribution, ensuring broader platform and architecture compatibility, and update Python version support to include newer pre-releases while deprecating an older, unsupported version. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request modernizes the PyPI publishing pipeline by adopting trusted publishing and updating the supported Python versions. The changes in pyproject.toml correctly remove support for Python 3.8 and add classifiers for the upcoming 3.13 and 3.14 versions, which aligns with the PR's goal. I've suggested one improvement for forward-compatibility regarding the Python version specifier.
| {name = "vvanglro", email = "vvanglro@gmail.com"} | ||
| ] | ||
| requires-python = ">=3.8" | ||
| requires-python = ">=3.9" |
There was a problem hiding this comment.
To improve forward-compatibility, it's recommended to specify an upper bound on the Python version. This prevents the package from being installed on future major Python versions (like Python 4) that may introduce breaking changes. While your package might work, explicitly capping the version range is a safer, forward-looking approach.
| requires-python = ">=3.9" | |
| requires-python = ">=3.9, <4" |
BREAKING CHANGE: python 3.8 support sunset; minimum runtime now 3.9