Use IMPORTED_TARGET for 3rd-party dependencies #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diizzyy
reviewed
Oct 4, 2024
evan-goode
reviewed
Mar 6, 2025
Member
evan-goode
left a comment
evan-goode
left a comment
There was a problem hiding this comment.
Sorry for the delay, LGTM. CI tests pass locally.
This requires CMake 3.6
Is it 3.7 actually? https://cmake.org/cmake/help/latest/module/FindPkgConfig.html#command:pkg_check_modules says IMPORTED_TARGET was added in 3.7.
The current CMakeLists.txt fails to include the required link directories for 3rd-party packages. As an example, on FreeBSD where packages are installed under /usr/local, the link lines include -lgio-2.0 but not -L/usr/local/lib. The suggested solution is to use the IMPORTED_TARGET mode of pkg_check_modules. This requires CMake 3.6, so I have bumped the minimum required version.
Member
|
Thanks! I also added the minimum CMake version in the spec file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current CMakeLists.txt fails to include the required link directories for 3rd-party packages. As an example, on FreeBSD where packages are installed under /usr/local, the link lines include -lgio-2.0 but not -L/usr/local/lib.
The suggested solution is to use the IMPORTED_TARGET mode of pkg_check_modules. This requires CMake 3.6, so I have bumped the minimum required version.