cmake: Allow builds without Doxygen being present with CMake 4+ #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With CMake 4+, the initial CMake run fails with
CMake Error at doc/CMakeLists.txt:18 (ADD_DEPENDENCIES):
The dependency target "doc-c" of target "doc" does not exist.
in case Doxygen is not installed on the system, since non-existent dependencies
are not ignored anymore (see [0]). Rectify that by making sure that we only add
the dependency in case Doxygen has been found.
[0]: https://cmake.org/cmake/help/latest/policy/CMP0046.html
... as part of my first contribution to the project.
moha-gh
commented
Jun 23, 2025
ppisar
approved these changes
Jun 23, 2025
Contributor
ppisar
left a comment
ppisar
left a comment
There was a problem hiding this comment.
I'm not sure why to obfuscate you e-mail address in AUTHORS file when it is in git log. But never mind.
Contributor
Author
Oh well, I guess I just went along with what others had done without thinking too much 😁 |
Contributor
Author
|
@ppisar : Are there any plans for a new release to ship the other CMake 4+ related fixes that went in recently and this one? That would come in handy since I'm trying to get CMake bumped to 4+ in Yocto (which ships |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With CMake 4+, the initial CMake run fails with
in case Doxygen is not installed on the system, since non-existent dependencies
are not ignored anymore (see 0). Rectify that by making sure that we only add
the dependency in case Doxygen has been found.