spec: Consistently use CMake RPM macros #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fedora is going to move from cmake with make to cmake with ninja <https://fedoraproject.org/wiki/Changes/CMake_ninja_default>. That would break building an RPM package from our spec file because the new %cmake macro won't produce Makefiles: + make -j8 'RPM_OPT_FLAGS=-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Wno-complain-wrong-lang -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer' make: *** No targets specified and no makefile found. Stop. The fix is to use CMake RPM macros for everything, especially not executing make manually. I tested this fix with old (make-based) and new (ninja-based) cmake-rpm-macros package successfully. Resolve: https://bugzilla.redhat.com/show_bug.cgi?id=2380983
Contributor
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora is going to move from cmake with make to cmake with ninja https://fedoraproject.org/wiki/Changes/CMake_ninja_default. That would break building an RPM package from our spec file because the new %cmake macro won't produce Makefiles:
The fix is to use CMake RPM macros for everything, especially not executing make manually.
I tested this fix with old (make-based) and new (ninja-based) cmake-rpm-macros package successfully.
Resolve: https://bugzilla.redhat.com/show_bug.cgi?id=2380983