Rsarwad move s1ap state ctx#26
Conversation
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…agma into rsarwad_move_s1ap_state_ctx
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
|
❌ The Semantic PR check ended with status failure. See instructions on formatting your commit and pull request titles. |
| ha_agw_offload_req_t* offload_request = | ||
| (ha_agw_offload_req_t*)callback_data->request; | ||
| s1ap_state_t* s1ap_state = (s1ap_state_t*)callback_data->s1ap_state; | ||
| S1apState* s1ap_state = (S1apState*)callback_data->s1ap_state; |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Using C-style cast. Use reinterpret_cast<S1apState*>(...) instead [readability/casting] [4]
| AssertFatal( | ||
| is_initialized, | ||
| "S1apStateManager init() function should be called to initialize state"); | ||
| // TODO: Add check for reentrant read/write function, to block multiple |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
072426f to
11e0b70
Compare
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
11e0b70 to
19d5564
Compare
| num_erab = e_rab_to_be_switched_dl_list_req->list.count; | ||
| for (index = 0; index < num_erab; ++index) { | ||
| eRABToBeSwitchedDlItemIEs_p = | ||
| (S1ap_E_RABToBeSwitchedDLItemIEs_t*) |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Using C-style cast. Use reinterpret_cast<S1ap_E_RABToBeSwitchedDLItemIEs_t*>(...) instead [readability/casting] [4]
| blk2bstr(eRab_ToBeSwitchedDLItem->transportLayerAddress.buf, | ||
| eRab_ToBeSwitchedDLItem->transportLayerAddress.size); | ||
| e_rab_to_be_switched_dl_list.item[index].gtp_teid = | ||
| htonl(*((uint32_t*)eRab_ToBeSwitchedDLItem->gTP_TEID.buf)); |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Using C-style cast. Use reinterpret_cast<uint32_t*>(...) instead [readability/casting] [4]
a08b1e8 to
5db2c25
Compare
…ructure,S1apState Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
5db2c25 to
dad8f87
Compare
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
e72dbc4 to
271f4be
Compare
…agma into rsarwad_move_s1ap_state_ctx
3f72981 to
8c09608
Compare
…#13983) Signed-off-by: Alex Jahl <alexander.jahl@tngtech.com> Signed-off-by: Alex Jahl <alexander.jahl@tngtech.com>
…agma into rsarwad_move_s1ap_state_ctx Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
* chore(magmad): Improve error handling of generic commands
Work in progress, orc8r (and possibly NMS) needs to be adapted.
Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
* Propagate Not Found error to orc8r
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
* Add information about configuration of generic commands
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
* Change default value of parameters field to use shell_params
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
* Handle further error cases
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
* Allow generic command to run with parameters `{"shell_params": []}`
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
Co-authored-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
Signed-off-by: Alex Jahl <alexander.jahl@tngtech.com> Signed-off-by: Alex Jahl <alexander.jahl@tngtech.com>
Testing: verified Registration with NetworkFeature IE support by configuring enable/disable Signed-off-by: ganeshg87 <ganesh.gedela@wavelabs.ai> Signed-off-by: ganeshg87 <ganesh.gedela@wavelabs.ai>
* feat(ci): Add docker promote script and workflow Taken from @ShubhamTatvamasi's repo (https://github.com/ShubhamTatvamasi/magma-artifactory-docker-promote/blob/master/.github/workflows/docker-promote.yml). Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * feat(ci): Add helm promote workflow Taken from @nstng's repo (https://github.com/nstng/magma-artifactory-helm-promote/blob/master/.github/workflows/helm-promote.yml). Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * feat(ci): Add docker promote script and workflow Taken from @ShubhamTatvamasi's repo (https://github.com/ShubhamTatvamasi/magma-artifactory-docker-promote/blob/master/.github/workflows/docker-promote.yml). Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * feat(ci): Small improvements to the docker promote workflow - Remove checkout action because we are using `wget` to get the `promote.sh` script. - Pin the docker login action to version 2.0.0. - Hand variables to `promote.sh` via environment variables, check at the beginning of the script that they exist. - Add an echo response at the end of the inner loop in `promote.sh` to log out which artifacts have been promoted. - Disable a shellcheck check. Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * feat(ci): Improved a logging string Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * feat(ci): Added double quotes Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * feat(ci): Improved docker-promote workflow - Added versions as inputs - Added check if user is a member of "approvers-ci" - fixed incorrect path to promote script Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * feat(ci): Improved docker-promote workflow - Added version as input - Added check if user is a member of "approvers-ci" Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * feat(ci): Fixed version pinning Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * feat(ci): Fixed version pinning Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * feat(ci): Simplified use of inputs Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * feat(ci): Improved the naming of some variables Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * feat(ci): Added license headers Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * feat(ci): Remove default values in promote workflows. Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
…s1ap module (magma#13728) * fix(agw): Added code to replace std:map wth protobuf map * fix(agw): Move the c files to cpp and fixed compilation errors * Changed the extension of header files to hpp in s1ap module * Modified code to replace hash list with protobuf map for s1ap module * Moved the map's unit test cases to common library * Replaced hashlist of UEs within eNB description to map in s1ap test module * Adding new file mme_init.hpp file * fix(agw): Modified code to replace hashlist with protobuf map for enb_description_t in s1ap module * fix(agw): Migrated hash table,mmeid2associd to protobuf map * Modified code to convert mme_ue_id_imsi_htbl to protobuf map * fix(agw): Migrate hash list of enb_description_t to protobuf_map * Modified code to use state_ue_map, declared new parameter in s1ap state manager * agw(fix): coverted C structure of ue context, ue_description_t to protobuf structure, UeDescription in s1ap module * Defined S1ap UE state in proto file and removed the enum definition from s1ap_types.hpp * Modified code to convert C structure to protobuf structure for enb context Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
|
Oops! Looks like you failed the Howto
♻️ Updated: ❌ The check is still failing the DCO check after the last commit. |
d7d1e9f to
b16660e
Compare
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
…a#14057) Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
…agma#14076) Signed-off-by: Alex Jahl <alexander.jahl@tngtech.com> Signed-off-by: Alex Jahl <alexander.jahl@tngtech.com>
Signed-off-by: tmdzk <timodzik@gmail.com> Signed-off-by: tmdzk <timodzik@gmail.com> Co-authored-by: tmdzk <timodzik@gmail.com>
…a#14077) Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
…14081) Signed-off-by: Alexander zur Bonsen <alexander.zur.bonsen@tngtech.com> Signed-off-by: Alexander zur Bonsen <alexander.zur.bonsen@tngtech.com>
…ed (magma#14020) * chore: deprecated packer templates for libvirt images are removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: deprecated packer images for debian machines are removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: deprecated aws images using debian are removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: deprecated `stretch_snapshot` ansible role is removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: deprecated `provision_stretch.sh` file is removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: several deprecated debian hints are removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: packer templates for Ubuntu 16.04 xenial are removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: temprary packer template for broken OVS are removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: incomplete packer template is removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: packer script for magma-dev vm is renamed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: `setup.sh` since all steps are included in `ubuntu_setup.sh` Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: next batch of debian scripts are removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: hints to debian OS are removed from Ansible roles Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: unused `envoy` Ansible role is removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: deprecated `uselocalpkgrepo` Ansible role is removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: readabilty of `magma-dev-virtualbox.json` is improved Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: hints to old `magma_dev_focal` are adapted Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
* fix(lte): Fixed `detect_init_system` - Added `exec_command_capture_output` to have an option to capture stdout and continue on non-zero exit codes. - Removed `_is_installed` function. - Simplified docker/systemd_magmad_running logic. - Renamed `MagmadUtil._data` to `MagmadUtil._credentials` and removed "command" key. - No longer write "command" to `MagmadUtil._credentials`, as this was not used anyway. Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * fix(lte): Added _is_installed check back in Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * fix(lte): Improve changes in previous commits - replace `&` with `and` in magmad running checks so that second condition is only evaluated if the first suceeds - Improved docstring of `exec_command_capture_output` - Added type hints to `exec_command`, `exec_command_output`, and `exec_command_capture_output` to highlight how these methods are different Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * fix(lte): Improve changes in previous commits - Perform sequential checks for installation and if magma is running - Remove exec_command_capture_output again as it is now unused Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * Revert "fix(lte): Improve changes in previous commits" This reverts commit 2bb7908. Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * fix(lte): Properly moved installation checks first Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
The concept of shared mconfig was added on the top level of the mconfig a while ago to handle configuration that is used in all services. However, the health cli tool is using the top-level entries of mconfig to decide which services to check. the shared mconfig needs to be excluded here. Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
Signed-off-by: Lucas Gonze <lucas@gonze.com>
Signed-off-by: Paulo Henrique Calaes Oliveira <paulo@radtonics.com> Co-authored-by: Paulo Henrique Calaes Oliveira <paulo@radtonics.com> Co-authored-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com> Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com> Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com> Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
* chore(ci): add workflow that runs s1ap integ tests against dockerized agw running on magma_dev VM Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com> Signed-off-by: Alexander zur Bonsen <alexander.zur.bonsen@tngtech.com> * chore(ci): correct spelling of set up Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com> * chore(ci): shorten and clarify docstring Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com> * chore(ci): improve whitespace consistency Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com> * chore(ci): remove debug output Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com> Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com> Signed-off-by: Alexander zur Bonsen <alexander.zur.bonsen@tngtech.com> Co-authored-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
Signed-off-by: Sathyaj27 <sathya.jayadev@wavelabs.ai> Signed-off-by: Sathyaj27 <sathya.jayadev@wavelabs.ai>
…14092) Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
a333a74 to
5d2e6db
Compare
…_state_ctx Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
| # to switch to a different release (for example v1.8) | ||
| git checkout v1.8 | ||
|
|
||
| # to switch to master (developement version) |
There was a problem hiding this comment.
[misspell] reported by reviewdog 🐶
"developement" is a misspelling of "development"
| ┏Access Control & ┓ ┏━━━━Session━━━━┓ │ ┏━━━━Device━━━━━┓ │┏━━━Optional━━━━┓ | ||
| ┃ Management ┃ ┃ & Policy ┃ │ ┃ Management ┃ │┃ Services ┃ | ||
| ┃ ┌───────────┐ ┃ ┃ Management ┃ │ ┃ ┌───────────┐ ┃ │┃ ┌────────────┐┃ | ||
| ┃ │ MME │ ┃ ┃ ┌───────────┐ ┃ └──╋─│ magmad │ ┃ │┃ │ monitord │┃ |
There was a problem hiding this comment.
[misspell] reported by reviewdog 🐶
"monitord" is a misspelling of "monitored"
|
|
||
| Dynamic services are optional AGW services that must be enabled by updating the AGW's *magmad* configuration. | ||
|
|
||
| ### Monitord |
There was a problem hiding this comment.
[misspell] reported by reviewdog 🐶
"Monitord" is a misspelling of "Monitored"
|
|
||
| ### Monitord | ||
|
|
||
| *monitord* service. Monitors the CPEs connected to the AGW. Sends ICMP pings to the CPEs connected to the gateway and reports liveness metrics. |
There was a problem hiding this comment.
[misspell] reported by reviewdog 🐶
"monitord" is a misspelling of "monitored"
Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com> Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
* Add new strtobool function Signed-off-by: Krisztián Varga <krisztian.varga@tngtech.com> * chore: Clean up boolean arguments in fabfiles Signed-off-by: Krisztián Varga <krisztian.varga@tngtech.com> Signed-off-by: Krisztián Varga <krisztian.varga@tngtech.com>
Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
…_state_ctx Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Summary
Test Plan
Additional Information