oddsare init - #1
Open
adamginzberg wants to merge 6 commits into
Open
adamginzberg wants to merge 6 commits into
adamginzberg wants to merge 6 commits into
Conversation
added 5 commits
February 17, 2018 08:48
adamginzberg
commented
Feb 18, 2018
| */ | ||
|
|
||
| project.ext.react = [ | ||
| entryFile: "artifacts/index.js" |
Collaborator
Author
There was a problem hiding this comment.
Edited this to redirect entrypoint to Typescript output.
adamginzberg
commented
Feb 18, 2018
|
|
||
| @Override | ||
| protected String getJSMainModuleName() { | ||
| return "artifacts/index"; |
Collaborator
Author
There was a problem hiding this comment.
Edited directly for Typescript output
adamginzberg
commented
Feb 18, 2018
| { | ||
| NSURL *jsCodeLocation; | ||
|
|
||
| jsCodeLocation = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"artifacts/index" fallbackResource:nil]; |
Collaborator
Author
There was a problem hiding this comment.
Edited directly for typescript output
atran3
approved these changes
Feb 19, 2018
adamginzberg
force-pushed
the
apg-init
branch
from
February 20, 2018 01:24
7a6f985 to
71af841
Compare
Collaborator
Author
|
@rsetaluri did you want to TAL before we merge? |
Owner
|
You're good to merge. |
Collaborator
Author
|
nit: prefer LGTM or approval of PR |
Owner
|
LGTM |
Collaborator
|
raj lbtm |
Owner
|
that's what they all say |
Collaborator
Author
|
If I've said it once, I've said it 1000 times. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PTAL: @atran3 @rsetaluri
Tried to remember to put most of the setup steps in the README but wouldn't be surprised if I forgot something.
Also copied most of the .gitignore from somewhere so the random android/ios files I think we are supposed to check in (also edited a few of them directly - notes inline).
Android/ios emulators: https://cl.ly/1v0v401w0Q2r