Skip shell env noise when matching pathbase templates - #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness of template detection and error handling in the
pathbasetemplate logic. The main changes focus on ensuring that only valid path templates are considered, and that errors in template pattern compilation are handled gracefully. Additionally, a new test ensures that shell environment variables that do not represent file paths are ignored.Template detection and validation:
_iter_template_itemsinlib/pathbase/template.pyto usestring.Formatter().parse()for validating template strings, ensuring only strings with valid template fields are considered, and added logic to skip invalid or non-template values. [1] [2]test_find_matching_templates_ignores_shell_env_values) intests/test_template.pyto verify that shell environment variables (such asBASH_FUNC_module%%) are ignored when searching for matching templates.Error handling improvements:
_compile_pattern()in theTemplateclass constructor with a try/except block to catch and re-raise regular expression errors asInvalidTemplateError, improving error reporting for invalid templates.