chore(ui): hide the plugin manager entry on mobile - #273
Conversation
Plugin panels are mobile-disabled in v1 (the !isMobile guard around openForNewTab in addTab — no touch close affordance, PR #265 scope), so on a phone the manager can only configure a feature that can never appear: installed + enabled + auto-open still renders nothing. Hide the settings entry via hiddenOnMobile to match; desktop (including compact narrow windows) is unchanged.
There was a problem hiding this comment.
🟡 Changes recommended
The current diff also changes desktop compact (<640px) Settings menu visibility in a way that contradicts the stated “desktop unchanged” scope.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR aims to avoid presenting a mobile “dead end” by hiding the Plugins manager entry in Settings on mobile devices, since plugin panels are explicitly disabled on mobile in v1.
Changes:
- Updates the Settings navigation filtering to hide the
pluginspage on mobile. - Adjusts which Settings pages are hidden under compact vs mobile filters.
File summaries
| File | Description |
|---|---|
| src/lib/components/SettingsLayout.svelte | Updates Settings menu visibility rules to hide Plugins on mobile (and modifies compact/mobile hide sets). |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| const hiddenOnCompact = new Set<string>([]); | ||
| const hiddenOnMobile = new Set<string>(["cli", "dynamic-discovery", "shortcuts", "plugins"]); |
|
The compact (<640px) change is intentional, not scope creep: |
Why
Plugin panels are explicitly mobile-disabled in v1:
addTab()wrapspluginStore.openForNewTab()inif (!isMobile && (ssh || local))(PR #265 scope — no touch close affordance; desktop closes via Esc). Auto-open is the only way a tab gets its areas opened, so on a phone the panel can never appear — verified on Android v0.3.0: plugin installed + enabled + auto-open on + new tab → nothing renders, by design.A visible manager that configures a feature that can never show is a dead end (install → enable → auto-open → nothing), so this hides the settings entry on mobile.
What
pluginson mobile — added tohiddenOnMobile, same treatment ascli/dynamic-discovery.hiddenOnCompact(narrow desktop windows <640px now showcli+shortcuts), movingshortcutsintohiddenOnMobile. Rationale:CliSettingscolumn-flex +overflow-x: autocode blocks;ShortcutsScreenmin-width: 0truncate chain).{cli, shortcuts, dynamic-discovery}— identical before/after for these two.Desktop (any width) keeps full plugin functionality; only the mobile entry point is removed.
Test
vitest run: 780 passed (62 files).svelte-check: error count identical before/after (all pre-existing in unrelated test files).