fix: make mapESLintTemplate optional with default value #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the API by making the mapESLintTemplate parameter optional with a default value of 'vanilla-ts'. This eliminates the need for test cases to explicitly provide () => null mappings when they don't need ESLint template customization.
Key changes:
- Made
mapESLintTemplateparameter optional in thecreatefunction - Added default behavior that uses
'vanilla-ts'when no custom mapping is provided - Removed redundant
mapESLintTemplate: () => nullfrom test cases that don't use ESLint
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/index.ts | Made mapESLintTemplate optional and implemented default 'vanilla-ts' behavior with JSDoc documentation |
| test/custom-tools.test.ts | Removed unnecessary mapESLintTemplate: () => null from two test cases that don't use ESLint |
| test/agents.test.ts | Removed unnecessary mapESLintTemplate: () => null from three test cases that don't use ESLint |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The mapESLintTemplate parameter is now optional with a default value of 'vanilla-ts'. This change simplifies the API by removing the need to explicitly provide a null mapping in test cases.