Skip to content

Replace/Update NuGet Packages that no longer exist.#143

Open
KeinNiemand wants to merge 3 commits into
rstewa:mainfrom
KeinNiemand:main
Open

Replace/Update NuGet Packages that no longer exist.#143
KeinNiemand wants to merge 3 commits into
rstewa:mainfrom
KeinNiemand:main

Conversation

@KeinNiemand

@KeinNiemand KeinNiemand commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

The package for CommunityToolkit.Labs.WinUI.MarqueeText no longer exists, making it impossible to build this project since nuget restore fails, so this PR replaces it with CommunityToolkit.Labs.WinUI.Controls.Marquee and makes necessary changes to get the new package to work.

Additionally, this PR upgrades CommunityToolkit.Labs.WinUI.Controls.MarkdownTextBlock to the latest version, since the version originally referenced no longer exists.

Not sure if everything still works—I was mainly concerned with trying to get things to build with the new replacement package.

@rstewa

rstewa commented Mar 29, 2026

Copy link
Copy Markdown
Owner

So I probably need to update the README but for future reference those packages do exist you just have to have the pre-release sources in your nuget config. But that's mute now that they've released prod versions of those. I'll try this out and if everything looks good, I'll merge your PR. Thanks for this!

@rstewa rstewa self-assigned this Mar 29, 2026
Comment thread Audibly.App/Audibly.App.csproj
@rstewa

rstewa commented Mar 29, 2026

Copy link
Copy Markdown
Owner

So this PR builds but does not run. I'll be able to take a more in depth look in a day or so but something in the xaml is breaking unfortunately.

@KeinNiemand

KeinNiemand commented Mar 29, 2026

Copy link
Copy Markdown
Contributor Author

It runs for me but I also got some extra changes to the build proccess and packging (dealing with the whole certicate thing), I also had to comment out the sentry init from App.xaml.cs but other then that it runs for me:

I did toggle on preview and still couldn't find CommunityToolkit.Labs.WinUI.MarqueeText; the other community toolkit packages exist but not that one, obviously for you it's still there because it's already installed and downloaded.

@eMarchOnward

eMarchOnward commented Mar 29, 2026 via email

Copy link
Copy Markdown

@rstewa

rstewa commented Mar 29, 2026

Copy link
Copy Markdown
Owner

@eMarchOnward I must have missed it, sorry about that! I'll take a look.

@rstewa

rstewa commented Mar 29, 2026

Copy link
Copy Markdown
Owner

It runs for me but I also got some extra changes to the build proccess and packging (dealing with the whole certicate thing), I also had to comment out the sentry init from App.xaml.cs but other then that it runs for me:

I did toggle on preview and still couldn't find CommunityToolkit.Labs.WinUI.MarqueeText; the other community toolkit packages exist but not that one, obviously for you it's still there because it's already installed and downloaded.

ahh that makes sense.

@KeinNiemand

Copy link
Copy Markdown
Contributor Author

What exactly does this break for you? Having to keep removing these dependency changes that I need to be able to build, before submitting any PR is a lot of extra work, so If I can, I'd like to fix any problem with this branch and get it merged.

@rstewa

rstewa commented Apr 5, 2026

Copy link
Copy Markdown
Owner

What exactly does this break for you? Having to keep removing these dependency changes that I need to be able to build, before submitting any PR is a lot of extra work, so If I can, I'd like to fix any problem with this branch and get it merged.

I get that. I'll be able to take another look at this tomorrow or the next day. Should be able to straighten it out. Probably just some xaml bs with a super generic error message lol.

Comment thread Audibly.App/Audibly.App.csproj
@rstewa

rstewa commented Apr 15, 2026

Copy link
Copy Markdown
Owner

What exactly does this break for you? Having to keep removing these dependency changes that I need to be able to build, before submitting any PR is a lot of extra work, so If I can, I'd like to fix any problem with this branch and get it merged.

Does it run for you? I'm getting a "{"The text associated with this error code could not be found.\r\n\r\nLayout cycle detected. Layout could not complete."}" error. It builds fine, but when I run it and try and play a book it crashes.

@KeinNiemand

KeinNiemand commented Apr 17, 2026

Copy link
Copy Markdown
Contributor Author

Yes it runs fine for me I can start playback and I don't get a crash and since I can't reproduce the problem I have no idea where to even look for a problem.
Does the error give you any information at least what xaml file is going wrong? (maybe with the debugger). Did you do a clean rebuild?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants