Skip to content

add support for m4a and ogg file formats #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Imrane64 wants to merge 1 commit into
base: main
Choose a base branch
from
+28 −4
Open

add support for m4a and ogg file formats #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions Audibly.App/Package.appxmanifest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,24 @@
<uap:EditFlags OpenIsSafe="true"/>
</uap:FileTypeAssociation>
</uap:Extension>
<uap:Extension Category="windows.fileTypeAssociation">
<uap:FileTypeAssociation Name="m4a">
<uap:SupportedFileTypes>
<uap:FileType>.m4a</uap:FileType>
</uap:SupportedFileTypes>
<uap:DisplayName>Audiobook Player</uap:DisplayName>
<uap:EditFlags OpenIsSafe="true"/>
</uap:FileTypeAssociation>
</uap:Extension>
<uap:Extension Category="windows.fileTypeAssociation">
<uap:FileTypeAssociation Name="ogg">
<uap:SupportedFileTypes>
<uap:FileType>.ogg</uap:FileType>
</uap:SupportedFileTypes>
<uap:DisplayName>Audiobook Player</uap:DisplayName>
<uap:EditFlags OpenIsSafe="true"/>
</uap:FileTypeAssociation>
</uap:Extension>
</Extensions>
</Application>
</Applications>
Expand Down
4 changes: 3 additions & 1 deletion Audibly.App/Services/FileImportService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,9 @@ public async Task ImportDirectoryAsync(string path, CancellationToken cancellati

var files = Directory.EnumerateFiles(path, "*.*", SearchOption.AllDirectories)
.Where(file => file.EndsWith(".m4b", StringComparison.OrdinalIgnoreCase) ||
file.EndsWith(".mp3", StringComparison.OrdinalIgnoreCase))
file.EndsWith(".mp3", StringComparison.OrdinalIgnoreCase) ||
file.EndsWith(".m4a", StringComparison.OrdinalIgnoreCase) ||
file.EndsWith(".ogg", StringComparison.OrdinalIgnoreCase))
.ToList();
var numberOfFiles = files.Count;

Expand Down
4 changes: 4 additions & 0 deletions Audibly.App/ViewModels/MainViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,6 +978,8 @@ public async void ImportAudiobookAsync()
openPicker.ViewMode = PickerViewMode.Thumbnail;
openPicker.FileTypeFilter.Add(".m4b");
openPicker.FileTypeFilter.Add(".mp3");
openPicker.FileTypeFilter.Add(".m4a");
openPicker.FileTypeFilter.Add(".ogg");

var file = await openPicker.PickSingleFileAsync();
if (file == null) return;
Expand Down Expand Up @@ -1176,6 +1178,8 @@ public async Task ImportAudiobookWithMultipleFilesAsync(object sender, RoutedEve
openPicker.ViewMode = PickerViewMode.Thumbnail;
openPicker.FileTypeFilter.Add(".m4b");
openPicker.FileTypeFilter.Add(".mp3");
openPicker.FileTypeFilter.Add(".m4a");
openPicker.FileTypeFilter.Add(".ogg");

var files = await openPicker.PickMultipleFilesAsync();
if (files.IsNullOrEmpty()) return;
Expand Down
6 changes: 3 additions & 3 deletions Audibly.App/Views/LibraryCardPage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@ public enum AudioBookFilter

#endregion

public const string ImportAudiobookText = "Import an audiobook (.m4b, mp3)";
public const string ImportAudiobookText = "Import an audiobook (.m4b, .mp3, .m4a, .ogg)";

public const string ImportAudiobooksFromDirectoryText =
"Import all audiobooks in a directory (recursively). Single-file audiobooks only (.m4b, mp3)";
"Import all audiobooks in a directory (recursively). Single-file audiobooks only (.m4b, .mp3, .m4a, .ogg)";

public const string ImportAudiobookWithMultipleFilesText =
"Import an audiobook made up of multiple files (.m4b, mp3)";
"Import an audiobook made up of multiple files (.m4b, .mp3, .m4a, .ogg)";

public const string ImportFromJsonFileText = "Import audiobooks from an Audibly export file (.audibly)";

Expand Down