Skip to content

Vignettes#102

Open
chendaniely wants to merge 3 commits intomainfrom
vignettes2
Open

Vignettes#102
chendaniely wants to merge 3 commits intomainfrom
vignettes2

Conversation

@chendaniely
Copy link
Contributor

@chendaniely chendaniely commented Mar 24, 2020

Resubmitting #78 but with just the .Rmd documents since there was a conflict in that PR

@chendaniely chendaniely mentioned this pull request Mar 24, 2020
Closed
2 tasks
@chendaniely
Copy link
Contributor Author

chendaniely commented Mar 24, 2020

Seem like the CI is failing because of Unittests. not because of the vignettes

schloerke
schloerke reviewed Mar 27, 2020
View reviewed changes
vignettes/z-developers_guide.Rmd Outdated

# In `learnr` documents

# Standalone
Copy link
Collaborator

@schloerke schloerke Mar 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file complete? Should it be included for now?

schloerke
schloerke reviewed Mar 27, 2020
View reviewed changes
vignettes/a-000-introduction_to_gradethis.Rmd Outdated
and pass in various `pass_if` and `fail_if` conditions.
The **first** condition that matches will return the corresponding feedback, i.e.,
if a `pass_if` case matches then the student's solution passed,
if a `fail_if case matches then the student's solution failed.
Copy link
Collaborator

@schloerke schloerke Mar 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing closing `

@schloerke
Copy link
Collaborator

schloerke commented Mar 27, 2020

A warning is being created due to the vigs.

* checking files in ‘vignettes’ ... WARNING
Files in the 'vignettes' directory but no files in 'inst/doc':
  ‘a-000-introduction_to_gradethis.Rmd’, ‘a-010-using_equal.Rmd’,
    ‘z-developers_guide.Rmd’
Package has no Sweave vignette sources and no VignetteBuilder field.

Call usethis::use_vignette("tmp") and delete the tmp vignette it creates. We're after the other side effects of the function.

@schloerke schloerke self-requested a review March 27, 2020 21:12
schloerke
schloerke requested changes Mar 27, 2020
View reviewed changes
Copy link
Collaborator

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@chendaniely chendaniely requested a review from schloerke May 27, 2020 20:09
@chendaniely
Copy link
Contributor Author

chendaniely commented Jan 26, 2021

@gadenbuie I heard that you are remaking these since the interface has changed drastically from the initial PR. So this PR can probably be closed.

Is there any vignette idea you would like written in its place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schloerke schloerke Awaiting requested review from schloerke

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chendaniely @schloerke