feat: confirm support title#67
Merged
simonguo merged 1 commit intorsuite:masterfrom Apr 1, 2025
Merged
Conversation
Member
myNameIsDu
commented
Mar 31, 2025
myNameIsDu
commented
There was a problem hiding this comment.
Pull Request Overview
A PR to add support for a custom title in the confirm dialog.
- Introduces new tests in confirm.test.js to verify the dialog's behavior with and without a custom title.
- Updates InteractionModal.jsx to conditionally render a header containing the custom title.
- Modifies demo/index.jsx to demonstrate usage of the custom title feature.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tests/confirm.test.js | Adds tests for verifying dialog title rendering. |
| src/InteractionModal.jsx | Renders Modal header with a custom title when provided. |
| demo/index.jsx | Demonstrates confirm usage with a custom title. |
Comments suppressed due to low confidence (1)
src/tests/confirm.test.js:32
- [nitpick] Consider revising the test name for grammatical consistency (e.g., 'shows dialog with custom title') to match the style of other tests.
it('show dialog with custom title', async () => {
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.