parser/rfc5424-date: allow to terminate on any non-alnum character#277
Open
julthomas wants to merge 1 commit intorsyslog:masterfrom
Open
parser/rfc5424-date: allow to terminate on any non-alnum character#277julthomas wants to merge 1 commit intorsyslog:masterfrom
julthomas wants to merge 1 commit intorsyslog:masterfrom
Conversation
Terminating on a space was too restrictive. The patch allow the match to terminate on any non-alnum character, thus allowing space, tab, comma, ...
julthomas
force-pushed
the
dev/jth/rfc5424
branch
from
a970dd0 to
1a907b3
Compare
rgerhards
requested changes
Jun 26, 2018
Member
rgerhards
left a comment
rgerhards
left a comment
There was a problem hiding this comment.
sorry for the late reply. The patch sounds to cause some issues with existing configs, also there are probably many cases where the strictness is required. I think we could re-use the idea of the "lazy" matching mode from the String parser: #299
Let me know if you would be interested in doing this, else I'll go over it in a while - especially as I am not sure you monitor the PR after that long time...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terminating on a space was too restrictive. The patch allow the
match to terminate on any non-alnum character, thus allowing space,
tab, comma, ...