LOGNORMALIZER::CHANGED:: when using '-V' flag, return 0 (zero) when program exits#365
Open
frikilax wants to merge 1 commit intorsyslog:masterfrom
Open
LOGNORMALIZER::CHANGED:: when using '-V' flag, return 0 (zero) when program exits#365frikilax wants to merge 1 commit intorsyslog:masterfrom
frikilax wants to merge 1 commit intorsyslog:masterfrom
Conversation
Member
|
oops... that sounds indeed bad. I would say this does not case a real backwards-compatibilty issue as the tool itself is not used that often. @davidelang what do you think (we are talking about the stand-alone tool, not the rsyslog integration)? |
Contributor
|
sounds like a mistake, and one that it's very unlikely that anyone is going to
depend on, so I would say it's reasonable to fix it.
David Lang
…On Thu, 13 Oct 2022, Rainer Gerhards wrote:
oops... that sounds indeed bad.
I would say this does not case a real backwards-compatibilty issue as the tool itself is not used that often. @davidelang what do you think (we are talking about the stand-alone tool, not the rsyslog integration)?
|
Member
|
@davidelang thx! |
rgerhards
approved these changes
Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When printing lognormalizer's version through its '-V' flag, the return code is not zero, that return code is counter intuitive and prevents using the command in scripts and/or CI/CD frameworks
Changed