Repeat - Fix multiple patterns with one name#369
Open
KGuillemot wants to merge 1 commit intorsyslog:masterfrom
Open
Repeat - Fix multiple patterns with one name#369KGuillemot wants to merge 1 commit intorsyslog:masterfrom
KGuillemot wants to merge 1 commit intorsyslog:masterfrom
Conversation
ab0ecce to
7f0874b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actual behavior
Actually, when using the following rulebase :
And the following line to parse :
I get the following error :
The error 'repeat' parser supports dot name only if single parser is used should be raised only if 2 parsers have a name configured.
Fixed behavior
After fixing, when using the rule and line listed above, the error does not raise and the parsing behavior is as expected.
Non-regression tests
After fix, the error correctly raises when multiple parsers use a name :