Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new configuration setting to control the maximum number of records exported in the
src/export.phpfile. The changes ensure that exports are limited based on this setting, improving performance and preventing excessive data handling.Configuration Update:
src/include/config.sample.php: Added a new configuration setting,ExportMaxRecords, with a default value of 10,000. This setting allows administrators to define the maximum number of records to export, with0indicating no limit.Export Logic Enhancement:
src/export.php: Introduced a variable$maxExportRecordsto fetch theExportMaxRecordsconfiguration value. If set to0, it defaults toPHP_INT_MAXto allow unlimited exports. This ensures flexibility in export limits.src/export.php: Updated the export loop condition to use$maxExportRecordsinstead of the previousCurrentViewEntriesPerPage, effectively enforcing the export limit.