Fix/general cleanup#321
Open
jrchamp wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi rtCamp team,
I was looking at this plugin for a lightweight Google login option. A quick review highlighted a few issues such as extract(), template variable naming and some leftover mentions of the 'github login' plugin that this plugin sourced.
In reviewing similar PRs, it looks like someone else was concerned about extract(). The benefit of this new PR is that it aligns with WordPress Coding standards, but please do credit them for their work.
Fixes #260
Fixes #267
Summary:
forceDisplayandforce_display_blocktemplate parameter mismatchextract()andarray_key_exists()