Skip to content

fix(cmrpc): release session when resend exhaustion aborts the AR #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acrews42 wants to merge 1 commit into
base: public
Choose a base branch
from
Open

fix(cmrpc): release session when resend exhaustion aborts the AR #601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/device/pf_cmrpc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1135,6 +1135,12 @@ static void pf_cmrpc_send_with_timeout (
pf_udp_close (p_net, p_sess->socket);
p_sess->socket = -1;
}
/* Release the session, or it stays in_use forever. With
* PF_MAX_SESSION = 2*PNET_MAX_AR + 1 sessions in total, a few
* unanswered CControl requests otherwise exhaust the pool and
* the device permanently logs "Out of session resources" for
* every subsequent incoming frame. */
pf_session_release (p_net, p_sess);
}
else
{
Expand All @@ -1148,6 +1154,8 @@ static void pf_cmrpc_send_with_timeout (
p_sess->p_ar->err_code =
PNET_ERROR_CODE_2_ABORT_AR_RPC_CONTROL_ERROR;
(void)pf_cmdev_cm_abort (p_net, p_sess->p_ar);
/* Same leak as the CControl branch above: release the session. */
pf_session_release (p_net, p_sess);
}
}
}
Expand Down