Updated package.json for Github user and Repo Name when install by npx#62
Open
HimanshuTembhe wants to merge 4 commits intorubemfsv:mainfrom
Open
Updated package.json for Github user and Repo Name when install by npx#62HimanshuTembhe wants to merge 4 commits intorubemfsv:mainfrom
HimanshuTembhe wants to merge 4 commits intorubemfsv:mainfrom
Conversation
Author
|
Pls review @rubemfsv |
rubemfsv
requested changes
Oct 11, 2023
Owner
rubemfsv
left a comment
rubemfsv
left a comment
There was a problem hiding this comment.
did you tested here to check if it will work?
| // Write the updated package.json back to the file | ||
| fs.writeFileSync(packageJsonPath, JSON.stringify(packageJson, null, 2)) | ||
|
|
||
| console.log('Updated package.json with dynamic values.') |
Owner
There was a problem hiding this comment.
it is not necessary, because it is not an instruction
Owner
There was a problem hiding this comment.
this line is missing! After remove it, run "npm run format:fix" to run prettier here
Author
|
Pls can you check once again |
rubemfsv
requested changes
Oct 12, 2023
| // Write the updated package.json back to the file | ||
| fs.writeFileSync(packageJsonPath, JSON.stringify(packageJson, null, 2)) | ||
|
|
||
| console.log('Updated package.json with dynamic values.') |
Owner
There was a problem hiding this comment.
this line is missing! After remove it, run "npm run format:fix" to run prettier here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for making a pull request!
Clean React App is built and maintained by developers like you, and we appreciate contributions very much. You are awesome!
Here is a short checklist to give your PR the best start:
Everything above can be removed once checked
fixes #55