Skip to content

Bugfix/issue 160 bug error message appears when visual studio reloads a project in a solution folder #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lachlan-trmb wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix/issue 160 bug error message appears when visual studio reloads a project in a solution folder #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4030946
Added null check when trying to get the language from a file extension
lachlan-trmb Oct 25, 2021
82013f9
Revert whitespace changes from previous commit
lachlan-trmb Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions LicenseHeaderManager.Core.Tests/LicenseHeaderReplacerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,16 @@ public void GetLanguageFromExtension_LanguagesAreEmpty_ReturnsNull ()
Assert.That (language, Is.Null);
}

[Test]
public void GetLanguageFromExtension_NullExtension_ReturnsNull()
{
var replacer = new LicenseHeaderReplacer(_languages, Enumerable.Empty<string>());

var language = replacer.GetLanguageFromExtension(null);

Assert.That(language, Is.Null);
}

[Test]
public void GetLanguageFromExtension_LanguagesAreNull_DoesNotThrowExceptionAndReturnsNull ()
{
Expand Down
3 changes: 3 additions & 0 deletions LicenseHeaderManager.Core/LicenseHeaderReplacer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ protected LicenseHeaderReplacer ()

public Language GetLanguageFromExtension (string extension)
{
if (extension == null)
return null;

return _languages?.FirstOrDefault (x => x.Extensions.Any (y => extension.EndsWith (y, StringComparison.OrdinalIgnoreCase)));
}

Expand Down