Skip to content

Fix locator #2588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soutaro merged 3 commits into from
Jul 6, 2025
Merged

Fix locator #2588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd43c2b
Fix locator position comparison
soutaro Jul 4, 2025
cfc783a
Expose `find_*` utility methods
soutaro Jul 4, 2025
a8d21ad
Merge branch 'master' into fix-locator
soutaro Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rbs/locator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ def find_in_loc(pos, location:, array:)

def test_loc(pos, location:)
if location
location.range === pos
location.start_pos <= pos && pos <= location.end_pos
else
false
end
Expand Down
2 changes: 0 additions & 2 deletions sig/locator.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ module RBS
#
def find2: (line: Integer, column: Integer) -> [Symbol?, Array[component]]?

private

def find_in_directive: (Integer pos, AST::Directives::t, Array[component]) -> bool

def find_in_decl: (Integer pos, decl: AST::Declarations::t, array: Array[component]) -> bool
Expand Down