Skip to content

Remove deprecated json/add/* types - #3081

Closed
byroot wants to merge 1 commit into
ruby:masterfrom
byroot:remove-json-add
Closed

Remove deprecated json/add/* types#3081
byroot wants to merge 1 commit into
ruby:masterfrom
byroot:remove-json-add

Conversation

@byroot

@byroot byroot commented Aug 11, 2026

Copy link
Copy Markdown
Member

I honestly don't know much about RBS, so unsure what exactly should be done.

But all these json/add/*.rb methods are gone in JSON 3.x: https://github.com/ruby/json/releases/tag/v3.0.0.rc1

So it's causing issues on ruby's master branch: ruby/ruby#18295

@soutaro

soutaro commented Aug 12, 2026

Copy link
Copy Markdown
Member

Thanks @byroot!
I think skipping tests with JSON 3.x would be better because the RBS tests should run with released versions of Ruby with JSON 2.x. #3084

@byroot

byroot commented Aug 12, 2026

Copy link
Copy Markdown
Member Author

Up to you, I don't have much context on RBS.

@soutaro soutaro closed this Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants