Change PrismRuby not to depend on hack that stores module nesting information to context.parent #1580
+36
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormation to context.parent All constant/module/class paths are resolved by PrismRuby parser itself. Resolves include/extend module name before adding it because `Context#parent` will not have an information for delayed full-path name resolve.
tompng
temporarily deployed
to
fork-preview-protection
GitHub Actions
Inactive
tompng
commented
Jan 24, 2026
| # Need to update module parent chain to emulate Module.nesting. | ||
| # This mechanism is inaccurate and needs to be fixed. | ||
| container.parent = old_container | ||
| end |
Member
Author
There was a problem hiding this comment.
RDoc::Parser::Ruby updates parent only for NormalClass. This information is used by includes/extends name resolve and also in CrossReference resolve.
This is one of the reason that HTML generated by RDoc::Parser::PrismRuby and RDoc::Parser::Ruby has huge diffs.
And there is no way to reduce diff except re-implementing many bugs.
Member
Author
There was a problem hiding this comment.
Changing this part to
container.parent = old_container if !singleton && container.is_a?(RDoc::NormalClass)will minimize crossref difference of generated HTML between two parsers.
(but this change doesn't make sense. It's just re-implementing a bug)
Collaborator
|
🚀 Preview deployment available at: https://f1a47501.rdoc-6cd.pages.dev (commit: 4776a83) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1291
All constant/module/class paths are resolved by PrismRuby parser itself.
Resolves include/extend module name before adding it because
Context#parentwill not have an information for delayed full-path name resolve.