Restore __main__ module after running a plugin.#11
Open
ext wants to merge 1 commit intorubys:masterfrom
Open
Conversation
If the plugin raises an exception (including SystemExit) the __main__ module is not properly loaded and it's __dict__ is lost. E.g. this causes errors when using any global variable in planet.py. I don't think is is a good idea to keep the plugin in memory (as __main__) anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the plugin raises an exception (including SystemExit) the
__main__module isnot properly loaded and it's
__dict__is lost. E.g. this causes errors whenusing any global variable in planet.py. I don't think is is a good idea to keep
the plugin in memory (as
__main__) anyway.The original problem I ran into was this:
Traceback (most recent call last): File "/path/to/venus/planet.py", line 91, in if config.pubsubhubbub_hub() and not no_publish: AttributeError: 'NoneType' object has no attribute 'pubsubhubbub_hub'This happened everytime a plugin (.plugin) raised an exception.