Sort activity tasks by progress#655
Open
chrisbrummel wants to merge 3 commits into
Open
Conversation
tillkruss
reviewed
Jun 10, 2026
tillkruss
left a comment
Collaborator
There was a problem hiding this comment.
Can you explain how you use this or what problem it's solving for you?
I usually see 2 items at most in my queue and they finish in less than a minute.
Author
|
A hypothetical, as I’m not interested in putting my situation in writing:
Someone asks to download 4 seasons of a show, but you have a show you’re
interested in showing up soon and want to manage downloads. Watching where
things are at with the progress allows you to make decisions as to which to
pause and which are so close you can allow to finish.
…On Jun 9, 2026 at 9:41:13 PM, Till Krüss ***@***.***> wrote:
***@***.**** commented on this pull request.
Can you explain how you use this or what problem it's solving for you?
I usually see 2 items at most in my queue and they finish in less than a
minute.
—
Reply to this email directly, view it on GitHub
<#655?email_source=notifications&email_token=AGWOPAQ2ZGG4K5ON5BIR3QD47DRGTA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBWGQ2TIOBTGA22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4464548305>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGWOPARI5ZYPJTN2VV5YUIL47DRGTAVCNFSM6AAAAACZX6DTROVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DINRUGU2DQMZQGU>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AGWOPAWQZVRYEFQMC3D3WST47DRGTA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBWGQ2TIOBTGA22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/AGWOPAVXSTWLVPJW7AG25NL47DRGTA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBWGQ2TIOBTGA22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Pull request overview
Adds a new “Progress” sort option to the Activity queue, including a shared progress fraction helper on QueueItem, and updates sorting behavior so actively-downloading items remain prioritized while sorting by progress.
Changes:
- Add
byProgressas a queue sort option (UI label + comparator). - Introduce
QueueItem.progressFractionand use it for both display and sorting. - Centralize queue sorting direction handling via
QueueSort.isOrderedBefore(removes post-sort reversing inActivityView).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Ruddarr/Views/ActivityView.swift | Switches queue sorting to use QueueSort.isOrderedBefore and removes manual reversal. |
| Ruddarr/Views/Activity/QueueSort.swift | Adds byProgress sort option and implements progress-aware ordering that prioritizes active downloads. |
| Ruddarr/Views/Activity/ActivityView+Toolbar.swift | Sets default sort direction for the new Progress option. |
| Ruddarr/Models/Queue/QueueItem.swift | Adds progressFraction helper and updates progress label logic to use it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Till Krüss <tillkruss@users.noreply.github.com>
tillkruss
approved these changes
Jun 24, 2026
tillkruss
left a comment
Collaborator
There was a problem hiding this comment.
have a look at this new logic and lmk if that works for you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
xcodebuild -project Ruddarr.xcodeproj -scheme Ruddarr -configuration Debug -destination id=0FEADBED-766F-4EEB-A07B-FC28167F9428 -derivedDataPath ./DerivedData-ProgressSortPR -skipPackagePluginValidation build.