Skip to content

ci: Run Rust tests on Ubuntu 24.04#16352

Merged
Dinnerbone merged 2 commits intoruffle-rs:masterfrom
torokati44:ci-ubuntu-24.04
Aug 6, 2024
Merged

ci: Run Rust tests on Ubuntu 24.04#16352
Dinnerbone merged 2 commits intoruffle-rs:masterfrom
torokati44:ci-ubuntu-24.04

Conversation

@torokati44
Copy link
Member

@torokati44 torokati44 commented May 17, 2024

Currently available as beta on GHA: https://github.blog/changelog/2024-05-14-github-hosted-runners-public-beta-of-ubuntu-24-04-is-now-available/

Just want to see whether anything will break once we switch, plus whether we can clean up the tricks we did to get Lavapipe, and to tolerate SIGABRT.

A minor added benefit is that we won't lose CI if/when Launchpad is down (as has happened a couple times recently), and that nextest will alert us of genuinely flaky tests with higher probability (the retries hack won't hide them). Also, the Ubuntu jobs will be a bit faster.

Note that after merging this, the set of required checks will have to be updated by a repo admin to match.

@torokati44
Copy link
Member Author

Looking good so far... 🥳 🤞
image

@torokati44 torokati44 force-pushed the ci-ubuntu-24.04 branch 2 times, most recently from 338dd87 to 59c24cc Compare July 2, 2024 09:17
@torokati44 torokati44 force-pushed the ci-ubuntu-24.04 branch 2 times, most recently from b609382 to 1a48cc1 Compare July 31, 2024 09:39
@torokati44
Copy link
Member Author

Posted actions/runner-images#10374 due to the Firefox WebDriver failures.

@torokati44
Copy link
Member Author

While the Edge people figure their shoot out, we could switch to 24.04 only for the Rust tests...?

@torokati44 torokati44 changed the title ci: Run Rust and Web tests on Ubuntu 24.04 ci: Run Rust tests on Ubuntu 24.04 Aug 2, 2024
@torokati44
Copy link
Member Author

While the Edge people figure their shoot out, we could switch to 24.04 only for the Rust tests...?

Removed the web test workflow updates from this PR, will submit those separately.

@torokati44 torokati44 marked this pull request as ready for review August 2, 2024 12:41
@torokati44
Copy link
Member Author

This and #17176 together will make our CI setup "relatively" hack-free again (well, aside from #16682).

Copy link
Contributor

@Dinnerbone Dinnerbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you <3

@Dinnerbone Dinnerbone enabled auto-merge (rebase) August 6, 2024 19:38
@Dinnerbone Dinnerbone merged commit feb9067 into ruffle-rs:master Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants