avm2: More work on the class refactor#16655
Merged
adrian17 merged 4 commits intoruffle-rs:masterfrom Jun 12, 2024
Merged
Conversation
8995fe1 to
cbe8d2a
Compare
adrian17
approved these changes
Jun 11, 2024
Also store a Class -> alias mapping instead of a ClassObject -> alias mapping for AMF.
1503f68 to
da2d946
Compare
Member
|
Note that this did not auto-merge, because the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is work on storing a
Classinstead of aClassObjectas an Object'sinstance_of, which is necessary for the refactor.Notable changes:
ClassObjectno longer stores its interfacesClassObjectno longer stores its type parameter, and theapplicationsmap is now aOption<Class>->ClassObjectmap instead of anOption<ClassObject>->ClassObjecthas_class_in_chainhas been moved toClassClassnow stores a list of all its interfaces (all_interfaces)ClassKeyandClassHashWrapperhave been removed as they were no longer necessary after avm2: Simplify uses ofGcCell<'gc, Class<'gc>>#16128VectorStoragenow stores the value type as aClassinstead of aClassObjectClassObjecthas been moved into its own function,ClassObject::parametrize