Map legend position to layers#6
Open
BalzGuenat wants to merge 6 commits into
Open
Conversation
Owner
|
Could we get the help icons to line up on the right? Also figure out a way to get the button centered, since it looks kind of awkward off to the side. And the text in the textboxes centered. We probably also want these settings saved in the json, which means the serialize() and deserialize() functions need to be changed while maintaining compatibility with older json files. And one more thing, can we get all the functions fully documented? There are a few that don't have docstrings above them. Other than that, looks like it works. Good job! |
Author
|
Thanks for the comments. I implemented your suggestions. (De-)Serialization code did not have to be changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.